14 Jun
2024
14 Jun
'24
3:19 p.m.
On Fri Jun 14 14:08:18 2024 +0000, Piotr Caban wrote:
I didn't try running your code but from a quick look I don't see anything missing in my implementation. There are some things missing in you patches (like e.g. handling of language resource files, dwFileType is set incorrectly). The biggest difference is in tests - I think it's better to test the function on generated file.
Missing things are a pretty minor detail, the patches could be improved if desired, for instance by sending improvements on top of existing patches instead of a completely new implementation. I'm mostly wanted to point out to a previous submission that was obviosuly ignored for unknown reasons.