Re: [PATCH 0/1] MR8858: sane.ds: Adding saving scanner settings to the registry

[Esme Povirk (＠madewokherd)]

Esme Povirk (@madewokherd) commented about dlls/sane.ds/ui.c:
>  len = lstrlenA(activeDS.identity.Manufacturer)
>       + lstrlenA(activeDS.identity.ProductName) + 2;
>  szCaption = malloc(len *sizeof(WCHAR));
> -
> - for (int i = 0; activeDS.identity.ProductFamily[i]; i++)
> - {
> -
>    if (activeDS.identity.ProductFamily[i] == L'/')
> -
>    {
> -
>        activeDS.identity.ProductFamily[i] = L'_';
> -
>    }
> - }

I'm not sure if it's safe to modify the TW_IDENTITY structure in this way. We should probably make a copy (or just allow slashes in the key name, it seems like the registry doesn't mind them).