On Fri May 3 15:23:33 2024 +0000, Jinoh Kang wrote:
How does this fix the bug? The bug is about SetEnvironmentVariableW. It's not about a program that indirectly uses it (explorer). If I changed this line to `SetLastError( -1 );` or `SetLastError( -GetLastError() );`, does it cause anything? I see nothing that relies on the last error value from this point onward. Again, I don't see how this fixes bug #50553 or anything related.
The first test case in that bug 50553 test has a wrong last error value when compared to Windows (Windows has ERROR_SUCCESS while Wine has ERROR_MOD_NOT_FOUND which comes from the LoadLibraryW() failure for winemac.drv which is a library that doesn't exist on Linux)