On Fri Sep 8 02:58:50 2023 +0000, Ziqing Hui wrote:
If we hold a `char *` in `wg_container_format`, it requires a pointer conversion from PE pointer to unix pointer when we are calling `wg_container_format_to_caps` in wg_muxer.c. Or we hold a `char[]` array in the struct to avoid the pointer conversion. But I preffer the intermediate enum approach. What do you think?
I don't know what you mean with pointer conversion but you have a wow64 thunk already anyway, so just do the conversion here.
I think the enum is just adding unnecessary abstraction and intermediate steps.