On Fri Aug 2 19:30:35 2024 +0000, Jacek Caban wrote:
If your tests are skipped on all Windows version we care about, they are not very useful. It would be more interesting to know what shell32 does, that's what you're aiming to fix anyway. There is no guarantee that it should do the same thing, esp. if the reference is some ancient IE.
This patch aims to implement IEParseDisplayNameWithBCW() which is an existing dependency that shell32 calls. The tests pass on XP where this export exists, and the implementation in this MR was created on the observed results of these tests . I.e. this MR implements an existing API that currently being called by shell32, and doesn't introduce anything new. Investigating what shell32 does is far beyond this MR, and putting burden on me to do that is not a fair move IMO.