On Tue Apr 2 23:00:27 2024 +0000, Rémi Bernon wrote:
Nit: Maybe make the buffer size depend on `SID_MAX_SUB_AUTHORITIES` to be safe (ie: `16 + 11 * (2 + SID_MAX_SUB_AUTHORITIES) + 1`), or C_ASSERT that it is larger?
I get 204 as the theoretical max size for this (`SID_MAX_SUB_AUTHORITIES` of 15, and `UINT_MAX` for everything). There's code like this (with buffer size of 256) in a number of places around the codebase (ntdll, opengl32, winealsa, winemac, winex11), I'd rather leave it alone unless there's a clear improvement.