Alfred Agrell (@Alcaro) commented about dlls/kernelbase/file.c:
return !oem_file_apis;}
+// uses the SetLastError style of error handling since CopyFileEx returns +// WIN32 error codes and HRESULT to WIN32 conversion is easier +// than the other way around.
-/***********************************************************************
- CopyFileExW (kernelbase.@)
- */
-BOOL WINAPI CopyFileExW( const WCHAR *source, const WCHAR *dest, LPPROGRESS_ROUTINE progress,
void *param, BOOL *cancel_ptr, DWORD flags )-{ +static BOOL CopyFile2_impl ( const PCWSTR source, const PCWSTR dest, COPYFILE2_EXTENDED_PARAMETERS* params) {
Should the asterisk be attached to the type or the name? You're doing one thing on params, and another on cancel_ptr ten lines down.
I have an opinion on that question, but I believe the Wine guideline is just 'stay consistent', so my opinion is irrelevant.