Re: [PATCH v29 4/4] kernel32: Implement GetFirmwareEnvironmentVariableExA, GetFirmwareEnvironmentVariableExW, GetFirmwareEnv

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=148325

Your paranoid android.

=== w10pro64_zh_CN (64 bit report) ===

kernel32:
console.c:5233: Test failed: test #5: CreateProcess failed: 1455 C:\Users\winetest\AppData\Local\Temp\console_cui.exe
console.c:5236: Test failed: test #5: Child didn't init 258 000000000000019C
console.c:5261: Test failed: test #5: Expecting child to be terminated
console.c:5266: Test failed: test #5: Couldn't get exit code
console.c:5268: Test failed: test #5: Unexpected exit code 0xfe, instead of 0

=== w1064_adm (64 bit report) ===

kernel32:
firmware.c:115: Test failed: Expected status > 0 or GetLastError() == ERROR_ENVVAR_NOT_FOUND, got error 1314.
firmware.c:132: Test failed: Expected ERROR_INVALID_PARAMETER, got error 1314.
firmware.c:137: Test failed: Expected ERROR_INVALID_PARAMETER, got error 1314.
firmware.c:142: Test failed: Expected status > 0 or GetLastError() == ERROR_ENVVAR_NOT_FOUND, got error 1314.
firmware.c:147: Test failed: Expected ERROR_ENVVAR_NOT_FOUND, got error 1314.
firmware.c:172: Test failed: Expected status > 0, got error 1314
firmware.c:190: Test failed: Expected ERROR_INVALID_PARAMETER, got error 1314.
firmware.c:195: Test failed: Expected ERROR_INVALID_PARAMETER, got error 1314.
firmware.c:200: Test failed: Expected status > 0 or GetLastError() == ERROR_ENVVAR_NOT_FOUND, got error 1314.
firmware.c:205: Test failed: Expected ERROR_ENVVAR_NOT_FOUND, got error 1314.
firmware.c:230: Test failed: Expected status > 0, got error 1314
firmware.c:249: Test failed: Expected ERROR_INVALID_PARAMETER, got error 1314.
firmware.c:254: Test failed: Expected ERROR_INVALID_PARAMETER, got error 1314.
firmware.c:259: Test failed: Expected status > 0 or GetLastError() == ERROR_ENVVAR_NOT_FOUND, got error 1314.
firmware.c:264: Test failed: Expected ERROR_INVALID_PARAMETER, got error 1314.
firmware.c:269: Test failed: Expected status > 0 or GetLastError() == ERROR_ENVVAR_NOT_FOUND, got error 1314.
firmware.c:274: Test failed: Expected ERROR_ENVVAR_NOT_FOUND, got error 1314.
firmware.c:299: Test failed: Expected status > 0, got error 1314
firmware.c:317: Test failed: Expected ERROR_INVALID_PARAMETER, got error 1314.
firmware.c:322: Test failed: Expected ERROR_INVALID_PARAMETER, got error 1314.
firmware.c:327: Test failed: Expected status > 0 or GetLastError() == ERROR_ENVVAR_NOT_FOUND, got error 1314.
firmware.c:332: Test failed: Expected ERROR_INVALID_PARAMETER, got error 1314.
firmware.c:337: Test failed: Expected status > 0 or GetLastError() == ERROR_ENVVAR_NOT_FOUND, got error 1314.
firmware.c:342: Test failed: Expected ERROR_ENVVAR_NOT_FOUND, got error 1314.

=== w10pro64_en_AE_u8 (32 bit report) ===

kernel32:
heap.c:3314: Test failed: HeapValidate failed
heap.c:3323: Test failed: HeapValidate failed

=== w1064_tsign (32 bit report) ===

kernel32:
process.c:2739: Test failed: expected 0 assigned processes, got 1
process.c:2739: Test failed: expected 0 process IDs, got 1

=== w864 (64 bit report) ===

kernel32:
process.c:2740: Test failed: expected 0 active processes, got 1

=== w1064_2qxl (64 bit report) ===

kernel32:
process.c:2739: Test failed: expected 0 assigned processes, got 1
process.c:2739: Test failed: expected 0 process IDs, got 1

=== w7u_2qxl (32 bit report) ===

ntdll:
info.c:348: Test failed: Expected ret_size == sizeof(SYSTEM_BOOT_ENVIRONMENT_INFORMATION).

=== w7u_adm (32 bit report) ===

ntdll:
info.c:348: Test failed: Expected ret_size == sizeof(SYSTEM_BOOT_ENVIRONMENT_INFORMATION).

=== w7u_el (32 bit report) ===

ntdll:
info.c:348: Test failed: Expected ret_size == sizeof(SYSTEM_BOOT_ENVIRONMENT_INFORMATION).

=== w1064_tsign (32 bit report) ===

ntdll:
info.c:369: Test failed: Expected STATUS_NOT_IMPLEMENTED on non-UEFI boots.
info.c:377: Test failed: Expected STATUS_SUCCESS or STATUS_VARIABLE_NOT_FOUND.
info.c:380: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:383: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:386: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:389: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:392: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:395: Test failed: Expected STATUS_SUCCESS.
info.c:398: Test failed: Expected STATUS_SUCCESS.
info.c:401: Test failed: Expected STATUS_SUCCESS.

=== w10pro64 (32 bit report) ===

ntdll:
info.c:369: Test failed: Expected STATUS_NOT_IMPLEMENTED on non-UEFI boots.
info.c:377: Test failed: Expected STATUS_SUCCESS or STATUS_VARIABLE_NOT_FOUND.
info.c:380: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:383: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:386: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:389: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:392: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:395: Test failed: Expected STATUS_SUCCESS.
info.c:398: Test failed: Expected STATUS_SUCCESS.
info.c:401: Test failed: Expected STATUS_SUCCESS.

=== w10pro64_en_AE_u8 (32 bit report) ===

ntdll:
info.c:369: Test failed: Expected STATUS_NOT_IMPLEMENTED on non-UEFI boots.
info.c:377: Test failed: Expected STATUS_SUCCESS or STATUS_VARIABLE_NOT_FOUND.
info.c:380: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:383: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:386: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:389: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:392: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:395: Test failed: Expected STATUS_SUCCESS.
info.c:398: Test failed: Expected STATUS_SUCCESS.
info.c:401: Test failed: Expected STATUS_SUCCESS.

=== w11pro64 (32 bit report) ===

ntdll:
info.c:369: Test failed: Expected STATUS_NOT_IMPLEMENTED on non-UEFI boots.
info.c:377: Test failed: Expected STATUS_SUCCESS or STATUS_VARIABLE_NOT_FOUND.
info.c:380: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:383: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:386: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:389: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:392: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:395: Test failed: Expected STATUS_SUCCESS.
info.c:398: Test failed: Expected STATUS_SUCCESS.
info.c:401: Test failed: Expected STATUS_SUCCESS.

=== w7pro64 (64 bit report) ===

ntdll:
info.c:348: Test failed: Expected ret_size == sizeof(SYSTEM_BOOT_ENVIRONMENT_INFORMATION).

=== w1064_2qxl (64 bit report) ===

ntdll:
info.c:369: Test failed: Expected STATUS_NOT_IMPLEMENTED on non-UEFI boots.
info.c:377: Test failed: Expected STATUS_SUCCESS or STATUS_VARIABLE_NOT_FOUND.
info.c:380: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:383: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:386: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:389: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:392: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:395: Test failed: Expected STATUS_SUCCESS.
info.c:398: Test failed: Expected STATUS_SUCCESS.
info.c:401: Test failed: Expected STATUS_SUCCESS.

=== w1064_adm (64 bit report) ===

ntdll:
info.c:369: Test failed: Expected STATUS_NOT_IMPLEMENTED on non-UEFI boots.
info.c:377: Test failed: Expected STATUS_SUCCESS or STATUS_VARIABLE_NOT_FOUND.
info.c:380: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:383: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:386: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:389: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:392: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:395: Test failed: Expected STATUS_SUCCESS.
info.c:398: Test failed: Expected STATUS_SUCCESS.
info.c:401: Test failed: Expected STATUS_SUCCESS.

=== w1064_tsign (64 bit report) ===

ntdll:
info.c:369: Test failed: Expected STATUS_NOT_IMPLEMENTED on non-UEFI boots.
info.c:377: Test failed: Expected STATUS_SUCCESS or STATUS_VARIABLE_NOT_FOUND.
info.c:380: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:383: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:386: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:389: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:392: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:395: Test failed: Expected STATUS_SUCCESS.
info.c:398: Test failed: Expected STATUS_SUCCESS.
info.c:401: Test failed: Expected STATUS_SUCCESS.

=== w10pro64 (64 bit report) ===

ntdll:
info.c:369: Test failed: Expected STATUS_NOT_IMPLEMENTED on non-UEFI boots.
info.c:377: Test failed: Expected STATUS_SUCCESS or STATUS_VARIABLE_NOT_FOUND.
info.c:380: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:383: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:386: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:389: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:392: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:395: Test failed: Expected STATUS_SUCCESS.
info.c:398: Test failed: Expected STATUS_SUCCESS.
info.c:401: Test failed: Expected STATUS_SUCCESS.

=== w10pro64_ar (64 bit report) ===

ntdll:
info.c:369: Test failed: Expected STATUS_NOT_IMPLEMENTED on non-UEFI boots.
info.c:377: Test failed: Expected STATUS_SUCCESS or STATUS_VARIABLE_NOT_FOUND.
info.c:380: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:383: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:386: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:389: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:392: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:395: Test failed: Expected STATUS_SUCCESS.
info.c:398: Test failed: Expected STATUS_SUCCESS.
info.c:401: Test failed: Expected STATUS_SUCCESS.

=== w10pro64_ja (64 bit report) ===

ntdll:
info.c:369: Test failed: Expected STATUS_NOT_IMPLEMENTED on non-UEFI boots.
info.c:377: Test failed: Expected STATUS_SUCCESS or STATUS_VARIABLE_NOT_FOUND.
info.c:380: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:383: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:386: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:389: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:392: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:395: Test failed: Expected STATUS_SUCCESS.
info.c:398: Test failed: Expected STATUS_SUCCESS.
info.c:401: Test failed: Expected STATUS_SUCCESS.

=== w10pro64_zh_CN (64 bit report) ===

ntdll:
info.c:369: Test failed: Expected STATUS_NOT_IMPLEMENTED on non-UEFI boots.
info.c:377: Test failed: Expected STATUS_SUCCESS or STATUS_VARIABLE_NOT_FOUND.
info.c:380: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:383: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:386: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:389: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:392: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:395: Test failed: Expected STATUS_SUCCESS.
info.c:398: Test failed: Expected STATUS_SUCCESS.
info.c:401: Test failed: Expected STATUS_SUCCESS.

=== w11pro64_amd (64 bit report) ===

ntdll:
info.c:369: Test failed: Expected STATUS_NOT_IMPLEMENTED on non-UEFI boots.
info.c:377: Test failed: Expected STATUS_SUCCESS or STATUS_VARIABLE_NOT_FOUND.
info.c:380: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:383: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:386: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:389: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:392: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:395: Test failed: Expected STATUS_SUCCESS.
info.c:398: Test failed: Expected STATUS_SUCCESS.
info.c:401: Test failed: Expected STATUS_SUCCESS.