Re: [PATCH v3 0/1] MR8237: kernelbase: Implement HeapSummary

[Alexandre Julliard (＠julliard)]

Alexandre Julliard (@julliard) commented about dlls/kernelbase/memory.c:
> -
>    (void) HeapUnlock( heap );
> -
>    return FALSE;
> - }
> -
> - if (!HeapUnlock( heap ))
> -
>    return FALSE;
> -
> - heap_summary->cbAllocated = allocated;
> - heap_summary->cbCommitted = committed;
> - heap_summary->cbReserved = committed + uncommitted;
> - heap_summary->cbMaxReserve = heap_summary->cbReserved;
> -
> - /* restore previous last error on success to make it look
> -
>   unchanged for the caller. */
> - SetLastError(last_error);
> - return TRUE;

Last error can be set at any point, it's not useful to preserve it unless an actual app depends on that behavior.