Rémi Bernon (@rbernon) commented about dlls/dmime/midi.c:
{if ((hr = read_variable_length_number(stream, &length, bytes_left)) != S_OK) return hr;length = length << 8 | (byte & 0x7f);}else length = byte;if (*bytes_left < length) return S_FALSE;offset.QuadPart = length;if (FAILED(hr = IStream_Seek(stream, offset, STREAM_SEEK_CUR, NULL))) return hr;*bytes_left -= length;FIXME("MIDI sysex event type %#02x, length %lu, time +%lu. not supported\n", status, length, delta_time);- }
- else
- {
if ((status & 0xf0) != 0xc0 && (status & 0xf0) != 0xd0)if ((hr = stream_read_at_most(stream, &byte, 1, bytes_left)) != S_OK) return hr;
Nit: What about combining the ifs with &&, or bracing the outermost one? I think this looks a bit wobbly.