On Tue Jun 18 10:54:15 2024 +0000, Nikolay Sivov wrote:
DB_S_ERRORSOCCURRED is a success return code. Is it possible we need != S_OK check instead then for this new trace, if we need it at all?
Yes it is but then it's propagate back to to GetDataSource, which shouldn't return this value.
We don't need the trace and it can be removed. This was just an easy way to workout exactly what was wrong.
Would you happy with something like ``` /* Return S_OK for any success code. */ if(SUCCEEDED(hr)) hr = S_OK; ```