Re: [PATCH v9 0/5] MR2091: windows.media.speech: Initial Unixlib work.

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/windows.media.speech/recognizer.c:
> +static HRESULT recognizer_factory_create_vosk_instance(struct session *session)
> +{
> - struct vosk_create_params vosk_create_params = { 0 };
> - WCHAR locale[LOCALE_NAME_MAX_LENGTH];
> - NTSTATUS status;
> - INT len;
> -
> - if (!(len = GetUserDefaultLocaleName(locale, LOCALE_NAME_MAX_LENGTH)))
> -
>    return E_FAIL;
> -
> - if (CharLowerBuffW(locale, len) != len)
> -
>    return E_FAIL;
> -
> - if (!WideCharToMultiByte(CP_ACP, 0, locale, -1, (LPSTR)vosk_create_params.locale, len, NULL, NULL))
> -
>    return HRESULT_FROM_WIN32(GetLastError());
> -

```suggestion:-2+0
    if (!WideCharToMultiByte(CP_ACP, 0, locale, len, vosk_create_params.locale, ARRAY_SIZE(vosk_create_params.locale), NULL, NULL))
        return HRESULT_FROM_WIN32(GetLastError());

```