23 Aug
2023
23 Aug
'23
3:59 a.m.
1/7, 2/7, and 4/7 add dead code, and I cannot easily guess how 1/7 and 2/7 will be used.1/7, 2/7, and 4/7 add dead code, and I cannot easily guess how 1/7 and 2/7 will be used.
1/7 and 2/7 is used here: https://gitlab.winehq.org/wine/wine/-/merge_requests/3303/diffs?commit_id=cb...
4/7 is just to do dynamic linking like you said below.
How much utility does 3/7 add? It's just push_event() but it emits GST_ERROR. In what cases is GStreamer not already emitting that error? Then again, if it makes debugging easier I won't argue against it.
The main purpose of 3/7 is to display the event type name which I think makes debug easiser.
7/7 does not at all do what it says it does.
Any suggestion on 7/7? Change the commit message or split into 2 patches?