Re: [PATCH v2 0/2] MR57: tests: Print d3dcompiler_47.dll version when running tests on Windows.

[Henri Verbeet (＠hverbeet)]

>  START_TEST(shader_runner)
>  {
> -#ifdef _WIN32
> +#ifdef VKD3D_CROSSTEST
>      run_shader_tests_d3d9(argc, argv);
>      run_shader_tests_d3d11(argc, argv);
>  #else

Overall this is probably an improvement, but I think that ideally we would run the d3d9 and d3d11 tests on any Win32 build, and always run the Vulkan and d3d12 tests. (Not sure if that's currently feasible; maybe it isn't.)
> +        if (GetFileVersionInfoA(file_name, handle, size, data))
> +        {
> +            VS_FIXEDFILEINFO *pFixedVersionInfo;
> +            UINT len;
> +
> +            if (VerQueryValueA(data, "\\", (LPVOID *)&pFixedVersionInfo, &len))
> +            {
> +                trace("%s version: %ld.%ld.%ld.%ld\n", file_name,
> +                        pFixedVersionInfo->dwFileVersionMS >> 16, pFixedVersionInfo->dwFileVersionMS & 0xffff,
> +                        pFixedVersionInfo->dwFileVersionLS >> 16, pFixedVersionInfo->dwFileVersionLS & 0xffff);
> +                done = true;
> +            }
> +        }

Sorry to be a pain about this, but could we please:

- Avoid "pFixedVersionInfo" and just call it "info", "version_info", "file_info", or something along those lines.
  - Avoid "LPVOID".
  - Use %u to print unsigned values.