14 Jul
2022
14 Jul
'22
11:13 a.m.
On Tue Jul 12 18:38:39 2022 +0000, **** wrote:
Zebediah Figura replied on the mailing list:
On 7/12/22 13:01, Claire Girka wrote: > From: Claire Girka <claire@sitedethib.com> > > --- > dlls/setupapi/devinst.c | 2 ++ > include/setupapi.h | 3 ++- > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/dlls/setupapi/devinst.c b/dlls/setupapi/devinst.c > index 73e721753aa..1282285da4c 100644 > --- a/dlls/setupapi/devinst.c > +++ b/dlls/setupapi/devinst.c > @@ -96,6 +96,7 @@ static const WCHAR Capabilities[] = {'C','a','p','a','b','i','l','i','t','i','e' > static const WCHAR UINumber[] = {'U','I','N','u','m','b','e','r',0}; > static const WCHAR UpperFilters[] = {'U','p','p','e','r','F','i','l','t','e','r','s',0}; > static const WCHAR LowerFilters[] = {'L','o','w','e','r','F','i','l','t','e','r','s',0}; > +static const WCHAR BaseContainerId[] = {'B','a','s','e','C','o','n','t','a','i','n','e','r','I','d',0}; > static const WCHAR Phantom[] = {'P','h','a','n','t','o','m',0}; > static const WCHAR SymbolicLink[] = {'S','y','m','b','o','l','i','c','L','i','n','k',0}; > static const WCHAR Control[] = {'C','o','n','t','r','o','l',0}; Can you please use wide-character constants for any new strings introduced? > @@ -654,6 +655,7 @@ static const struct PropertyMapEntry PropertyMap[] = { > { REG_DWORD, "UINumber", UINumber }, > { REG_MULTI_SZ, "UpperFilters", UpperFilters }, > { REG_MULTI_SZ, "LowerFilters", LowerFilters }, > + [0x24] = { REG_SZ, "BaseContainerId", BaseContainerId }, > }; Please use SPDRP_BASE_CONTAINERID instead of hardcoding the value. Also, are you sure that "BaseContainerId" is correct? On a Windows machine I see only "ContainerID"; is this supposed to be different somehow? _______________________________________________ wine-gitlab mailing list -- wine-gitlab@winehq.org To unsubscribe send an email to wine-gitlab-leave@winehq.org
Changed it to `ContainerID`, as it's indeed how it is stored in Windows' registry.