Re: [PATCH v4 0/1] MR364: kernel32/tests: Test module refcounting with forwarded exports.

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/kernel32/tests/loader.c:
> - WriteFile( file, ptr, SizeofResource( module, res ), &written, NULL );
> - ok( written == SizeofResource( module, res ), "couldn't write resource\n" );
> - CloseHandle( file );
>
> +}
> -
>
> +static void test_static_forwarded_import_refs(void)
> +{
> - CHAR temp_path[MAX_PATH], dir_path[MAX_PATH], sforward_path[MAX_PATH];
> - HMODULE iphlpapi, icmp, sforward;
> - FARPROC test_func_stub;
> -
> - if (GetModuleHandleA( "iphlpapi.dll" ))
> - {
> -
>    win_skip( "iphlpapi.dll already loaded, skipping\n" );
> -
>    return;
> - }

Imo it'd be better to avoid the skip unless there's actually cases where iphlpapi is already loaded. Otherwise we might end up breaking the test without noticing it (even though there's a comment, who trusts them anyway?).