On Fri Jan 24 19:06:36 2025 +0000, Gabriel Ivăncescu wrote:
I don't understand what's so difficult about also adding it to `abort_thread` that you had to close this? I never said you should make it tree-wide in a single MR, or even in other MRs if you don't feel like it. Any improvement, even partial, is still fine. But since you already touch this component, why not just add it to `abort_thread` as well? Anyway, the other thing is it still should be encapsulated in a macro, IMO. Still waiting for Alexandre's suggestion(s) on that one. The scope of this MR is fine as-is.
It's not "so difficult", I closed it because the MR doesn't make sense to me anymore if it's no longer just focused on fixing what's broken. This approach generally feels wrong to me if, to continue with fixing the PE-side, we'd have to do something similar for dozens of other occurrences. Like I mentioned, I believe there is a better ("lazier") way to make sure the compiler behaves properly with inline asm function calls, instead of manual additions. I will explore other options.