Re: [PATCH v3 0/9] MR4438: dmime, dmsynth: Message ordering fixes.

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/dmime/performance.c:
> +static HRESULT performance_queue_message(struct performance *This, struct message *message, struct list *hint)
> +{
> - static const DWORD delivery_flags = DMUS_PMSGF_TOOL_IMMEDIATE | DMUS_PMSGF_TOOL_QUEUE | DMUS_PMSGF_TOOL_ATTIME;
> - struct message *prev;
> - HRESULT hr;
> -
> - for (;;)
> - {
> -
>    if ((message->msg.dwFlags & delivery_flags) == DMUS_PMSGF_TOOL_QUEUE)
> -
>        break;
> -
>    if ((message->msg.dwFlags & delivery_flags) == DMUS_PMSGF_TOOL_ATTIME)
> -
>        break;
> -
>    if ((message->msg.dwFlags & delivery_flags) != DMUS_PMSGF_TOOL_IMMEDIATE)
> -
>        WARN("No delivery flag found for message %p\n", &message->msg);
> -

```suggestion:-6+0
        if ((message->msg.dwFlags & delivery_flags) != DMUS_PMSGF_TOOL_IMMEDIATE)
            break;
```

(I'm not sure the WARN really matter here, but if it does maybe it could go into the performance_get_message switch?)