Re: [PATCH v4 0/9] MR8829: windows.media.playback.mediaplayer: Return S_OK from IMediaPlayer2::get_SystemMediaTransportControls().

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/windows.media.playback.mediaplayer/main.c:
> - media_player_remove_BufferingStarted,
> - media_player_add_BufferingEnded,
> - media_player_remove_BufferingEnded,
> - media_player_Play,
> - media_player_Pause,
> - media_player_SetUriSource,
>
> +};
> -
>
> +DEFINE_IINSPECTABLE( media_player2, IMediaPlayer2, struct media_player, IMediaPlayer_iface )
> -
>
> +static HRESULT WINAPI media_player2_get_SystemMediaTransportControls( IMediaPlayer2 *iface, ISystemMediaTransportControls **value )
> +{
> - FIXME( "iface %p, value %p stub!\n", iface, value );
> - *value = NULL;
> - return S_OK;
>
> +}

Usual convention is to return valid instance if method succeeded.