27 Sep
2023
27 Sep
'23
5:28 p.m.
On Wed Sep 27 17:28:38 2023 +0000, Henri Verbeet wrote:
if (param->reg.type != VKD3DSPR_IMMCONST && param->reg.type != VKD3DSPR_IMMCONST64 - && param->reg.type != VKD3DSPR_SAMPLER) + && param->reg.dimension == VSIR_DIMENSION_VEC4)Does that make the IMMCONST/IMMCONST64 checks redundant as well?
VKD3DSPR_IMMCONST64~s have dimension VSIR_DIMENSION_VEC4 but their swizzles are not intended to be used nor shown. shader_dump_register() takes care of showing the immconst as an expression such as `l(1.0, 2.0, 3.0, 4.0)`.
On the other hand we could get rid of the check for the regular VKD3DSPR_IMMCONST~s since they have dimension VSIR_DIMENSION_SCALAR, but it feels right to keep it for documentation purposes, since their swizzles are also not intended to be used nor shown.