Re: [PATCH v3 0/4] MR1502: Draft: winevulkan: wow64 memory mapping using VK_EXT_external_memory_host

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/winevulkan/vulkan.c:
> -
>    if (result != VK_SUCCESS)
> -
>    {
> -
>        ERR("vkGetMemoryHostPointerPropertiesEXT failed: %d\n", result);
> -
>        return result;
> -
>    }
> -
> -
>    if (!(props.memoryTypeBits & (1u << info.memoryTypeIndex)))
> -
>    {
> -
>        for (i = 0; i < device->phys_dev->memory_properties.memoryTypeCount; i++)
> -
>        {
> -
>            if (!(props.memoryTypeBits & (1u << i)))
> -
>                continue;
> -
>            flags = device->phys_dev->memory_properties.memoryTypes[i].propertyFlags;
> -
>            flags = flags & ~VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT;
> -
>            mem_flags = flags & ~VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT;
> -
>            if ((flags & mem_flags) == mem_flags)

Just skimming through... Is this right?