[PATCH v2 14/14] mshtml: Implement removeChild for attributes.

[Gabriel Ivăncescu]

From: Gabriel Ivăncescu

Signed-off-by: Gabriel Ivăncescu 
---
 dlls/mshtml/htmlattr.c  | 8 ++++++--
 dlls/mshtml/tests/dom.c | 8 ++++++++
 2 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/dlls/mshtml/htmlattr.c b/dlls/mshtml/htmlattr.c
index e1dc4523e85..d1e8a8e71bb 100644
--- a/dlls/mshtml/htmlattr.c
+++ b/dlls/mshtml/htmlattr.c
@@ -324,8 +324,12 @@ static HRESULT WINAPI HTMLDOMAttribute2_removeChild(IHTMLDOMAttribute2 *iface, I
         IHTMLDOMNode **node)
 {
     HTMLDOMAttribute *This = impl_from_IHTMLDOMAttribute2(iface);
-    FIXME("(%p)->(%p %p)\n", This, oldChild, node);
-    return E_NOTIMPL;
+
+    TRACE("(%p)->(%p %p)\n", This, oldChild, node);
+
+    /* mostly a stub, doesn't really remove anything on native either */
+    *node = NULL;
+    return S_OK;
 }

static HRESULT WINAPI HTMLDOMAttribute2_appendChild(IHTMLDOMAttribute2 *iface, IHTMLDOMNode *newChild,
diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c
index 81a1e5c1031..dd987350e72 100644
--- a/dlls/mshtml/tests/dom.c
+++ b/dlls/mshtml/tests/dom.c
@@ -10061,6 +10061,14 @@ static void test_attr_node(IHTMLDOMAttribute *test_attr, IHTMLDocument2 *doc)
     ok(hres == S_OK, "replaceChild failed: %08lx\n", hres);
     ok(!node, "replaced node != NULL\n");

+    hres = IHTMLDOMAttribute2_removeChild(attr, NULL, &node);
+    ok(hres == S_OK, "removeChild failed: %08lx\n", hres);
+    ok(!node, "removed node != NULL\n");
+
+    hres = IHTMLDOMAttribute2_removeChild(attr, elem_node, &node);
+    ok(hres == S_OK, "removeChild failed: %08lx\n", hres);
+    ok(!node, "removed node != NULL\n");
+
     IHTMLDOMNode_Release(elem_node);
     IHTMLDOMAttribute2_Release(attr);
 }