On Wed Aug 16 18:21:31 2023 +0000, Jeffrey Smith wrote:
- Seems more consistent to check these in the order: result, type,
start, end.
- You didn't initialize those values before the call.
I know the existing code is inconsistent, I was just thinking that checking the value in parameter order would be nice, here and a few other places in this MR.