Re: [PATCH v4 0/2] MR979: d3d9: Implement d3dx_effect_SetRawValue

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/tests/effect.c:
> -
> - an off-by-one byte alignment copied to them.
> -
> - See test_effect_setrawvalue_init_floats() below.
> -
> -
> -
> - E.x. arr[0] = (1.0f & 0x00FFFFFF) | 1.2f;
> - */
>
> +static float SET_RAWDATA_FLOAT4_BA[16] = { 1.2f, 0.0f, 0.0f, 0.0f, 1.0f, 1.0f, 1.0f, 1.0f, 1.0f,
> -
>    1.0f, 1.0f, 1.0f, 1.0f, 1.0f, 1.0f, 1.0f };
>
> +static float SET_RAWDATA_FLOAT4_BBA[16] = { 1.2f, 1.0f, 0.0f, 0.0f, 1.0f, 1.0f, 1.0f, 1.0f, 1.0f,
> -
>    1.0f, 1.0f, 1.0f, 1.0f, 1.0f, 1.0f, 1.0f };
>
> +static float SET_RAWDATA_FLOAT44_BA[16] = { 1.2f, 0.0f, 0.0f, 0.0f, 1.0f, 0.0f, 0.0f, 0.0f, 0.0f,
> -
>    0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 0.0f };
>
> +static float SET_RAWDATA_FLOAT44_BBA[16] = { 1.2f, 0.0f, 0.0f, 0.0f, 1.0f, 0.0f, 0.0f, 0.0f, 0.0f,
> -
>    0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 0.0f };
> -
>
> +struct test_set_raw_data_value test_set_raw_data_values[] =
> +{

You can probably move this inside the test function and rename it to just "tests".

It can also be const, I think.