Re: [PATCH 0/3] MR8757: winsock: Support IPv6 ping over dgram.

[Alfred Agrell (＠Alcaro)]

Alfred Agrell (@Alcaro) commented about dlls/ws2_32/tests/sock.c:
> - BYTE send_buf[sizeof(struct icmp_hdr) + sizeof(ping_data)];
> - struct ipv6_pseudo_header *ip_h;
> - UINT16 recv_checksum, checksum;
> - struct icmp_hdr *icmp_h;
> - unsigned int reply_data;
> - struct sockaddr_in6 sa;
> - BYTE chksum_buf[256];
> - BYTE recv_buf[256];
> - SOCKET s;
> - int ret;
> -
> - s = WSASocketA(AF_INET6, SOCK_RAW, IPPROTO_ICMPV6, NULL, 0, 0);
> - if (s == INVALID_SOCKET)
> - {
> -
>    ret = WSAGetLastError();
> -
>    ok(ret == WSAEACCES, "Expected 10013, received %d\n", ret);

IMO `ok(ret == WSAEACCES, "Expected %d, received %d\n", WSAEACCES, ret);` would be slightly cleaner.