Re: [PATCH 0/3] MR3810: winegstreamer: Implement add_stream and push_sample for muxer.

[Rémi Bernon (＠rbernon)]

On Wed Sep 13 10:34:46 2023 +0000, Ziqing Hui wrote:
> This line is added because mp4mux element only accpet h264 stream with
> "stream-format" be set to "avc" or "avc3".
> gst-inspect-1.0 mp4mux:
> [...]
> SINK template: 'video_%u'
>     Availability: On request
>     Capabilities:
>       video/mpeg
>             mpegversion: 4
>            systemstream: false
>                   width: [ 16, 2147483647 ]
>                  height: [ 16, 2147483647 ]
>       video/x-divx
>             divxversion: 5
>                   width: [ 16, 2147483647 ]
>                  height: [ 16, 2147483647 ]
>       video/x-h264
>           stream-format: { (string)avc, (string)avc3 }
>               alignment: au
>                   width: [ 16, 2147483647 ]
>                  height: [ 16, 2147483647 ]
>       video/x-h265
>           stream-format: { (string)hvc1, (string)hev1 }
>               alignment: au
>                   width: [ 16, 2147483647 ]
>                  height: [ 16, 2147483647 ]
>       video/x-mp4-part
>                   width: [ 16, 2147483647 ]
>                  height: [ 16, 2147483647 ]
>       video/x-av1
>                   width: [ 16, 2147483647 ]
>                  height: [ 16, 2147483647 ]
> [...]
>
> Should this be in wg_format_to_caps_video_h264()? Currently
> wg_format_to_caps_video_h264 set "stream-format" to "byte-stream". Is it
> OK to change the "byte-stream" to "avc" in wg_format_to_caps_video_h264()?

I have no idea whether that's right. Maybe it'd be better to figure the exact meaning, but as long as it doesn't break the H264 tests I'm probably fine with it.