Re: [PATCH 0/4] MR951: ntdll: Add initial support for DOS file attributes (attempt 3)

[Erich Hoover (＠ehoover)]

On Wed Sep 28 20:42:41 2022 +0000, **** wrote:
> Zebediah Figura replied on the mailing list:
> On 9/28/22 07:35, Erich E. Hoover wrote:
> > @@ -1505,6 +1540,11 @@ static int get_file_info( const char *path,
> struct stat *st, ULONG *attr )
> >           free( parent_path );
> >       }
> >       *attr |= get_file_attributes( st );
> > +
> > +    len = xattr_get( path, SAMBA_XATTR_DOS_ATTRIB, hexattr,
> sizeof(hexattr)-1 );
> > +    if (len != -1)
> > +        *attr |= get_file_xattr( hexattr, len );
> > +
> >       return ret;
> >   }
> >   
> Should we WARN or ERR if we get something other than ENODATA or ENOTSUP?

@zfigura I would suspect that if you got something else, it would probably be ERANGE and you would likely get it for every file...  That said, I doubt it would hurt anything.