16 Dec
2022
16 Dec
'22
11:23 p.m.
On Fri Dec 16 20:58:35 2022 +0000, Gerald Pfeifer wrote:
Yes, you're right: it was only necessary to avoid warnings with an earlier version of the patch. However, isn't it better to have variables at smaller scope? Not for the compiler, which will generate identical code, but for the human brain? I'll make the change if you wish, just wondering.
I don't have a strong opinion, although I tend to prefer having variables declared in one place, especially for small functions like this. In any case it's an unrelated and unnecessary change here.