Re: [PATCH v2 0/2] MR1917: [PATCH] shell32/tests: Workaround moving cursor to (0,0) coordinates.

[Gabriel Ivăncescu (＠insn)]

On Fri Jan  6 18:10:51 2023 +0000, **** wrote:
> Marvin replied on the mailing list:
> Hi,
> It looks like your patch introduced the new failures shown below.
> Please investigate and fix them before resubmitting your patch.
> If they are not new, fixing them anyway would help a lot. Otherwise
> please ask for the known failures list to be updated.
> The tests also ran into some preexisting test failures. If you know how
> to fix them that would be helpful. See the TestBot job for the details:
> The full results can be found at:
> https://testbot.winehq.org/JobDetails.pl?Key=128200
> Your paranoid android.
> === w1064v1809 (32 bit report) ===
> shell32:
> autocomplete.c:637: Test failed: Expected L"www.ac", got L"www.a"
> autocomplete.c:638: Test failed: AutoComplete DropDown not visible
> autocomplete.c:638: Test failed: AutoComplete DropDown not visible
> autocomplete.c:638: Test failed: Expected L"https://www.ac", got (null)
> autocomplete.c:638: Test failed: AutoComplete DropDown not visible
> autocomplete.c:638: Test failed: Expected L"http://www.add", got (null)
> autocomplete.c:638: Test failed: AutoComplete DropDown not visible
> autocomplete.c:638: Test failed: Expected L"www.ax", got (null)
> autocomplete.c:638: Test failed: AutoComplete DropDown not visible
> === w10pro64_en_AE_u8 (64 bit report) ===
> shell32:
> autocomplete.c:667: Test failed: Expected L"http://a0", got L"http://a"
> autocomplete.c:668: Test failed: AutoComplete DropDown not visible
> autocomplete.c:668: Test failed: AutoComplete DropDown not visible
> autocomplete.c:668: Test failed: Expected L"http://a0", got (null)
> autocomplete.c:668: Test failed: AutoComplete DropDown not visible
> autocomplete.c:668: Test failed: Expected L"http://abc.aa.com", got (null)
> autocomplete.c:668: Test failed: AutoComplete DropDown not visible
> === w10pro64_zh_CN (64 bit report) ===
> shell32:
> autocomplete.c:614: Test failed: Expected L"a0", got L"a"
> autocomplete.c:615: Test failed: AutoComplete DropDown not visible
> autocomplete.c:615: Test failed: AutoComplete DropDown not visible
> autocomplete.c:615: Test failed: Expected L"http://a0", got (null)
> autocomplete.c:615: Test failed: AutoComplete DropDown not visible
> autocomplete.c:615: Test failed: Expected L"aa", got (null)
> autocomplete.c:615: Test failed: AutoComplete DropDown not visible
> autocomplete.c:615: Test failed: Expected L"ab", got (null)
> autocomplete.c:615: Test failed: AutoComplete DropDown not visible
> autocomplete.c:615: Test failed: Expected L"http://abc.aa.com", got (null)
> autocomplete.c:615: Test failed: AutoComplete DropDown not visible
> autocomplete.c:615: Test failed: Expected L"https://www.ac", got (null)
> autocomplete.c:615: Test failed: AutoComplete DropDown not visible
> autocomplete.c:615: Test failed: Expected L"http://www.add", got (null)
> autocomplete.c:615: Test failed: AutoComplete DropDown not visible
> autocomplete.c:615: Test failed: Expected L"www.ax", got (null)
> autocomplete.c:615: Test failed: AutoComplete DropDown not visible
> autocomplete.c:623: Test failed: AutoComplete DropDown not visible
> autocomplete.c:623: Test failed: AutoComplete DropDown not visible
> autocomplete.c:623: Test failed: Expected L"ab", got (null)
> autocomplete.c:623: Test failed: AutoComplete DropDown not visible
> autocomplete.c:623: Test failed: Expected L"http://abc.aa.com", got (null)
> autocomplete.c:623: Test failed: AutoComplete DropDown not visible
> autocomplete.c:630: Test failed: Expected L"abc.aa.com", got L"abc"
> autocomplete.c:637: Test failed: Expected L"www.ac", got L"www.a"
> autocomplete.c:638: Test failed: AutoComplete DropDown not visible
> autocomplete.c:638: Test failed: AutoComplete DropDown not visible
> autocomplete.c:638: Test failed: Expected L"https://www.ac", got (null)
> autocomplete.c:638: Test failed: AutoComplete DropDown not visible
> autocomplete.c:638: Test failed: Expected L"http://www.add", got (null)
> autocomplete.c:638: Test failed: AutoComplete DropDown not visible
> autocomplete.c:638: Test failed: Expected L"www.ax", got (null)
> autocomplete.c:638: Test failed: AutoComplete DropDown not visible
> autocomplete.c:644: Test failed: Expected L"www.www.?", got L"www.w"
> autocomplete.c:650: Test failed: Expected L"hfoo", got L"h"
> autocomplete.c:651: Test failed: AutoComplete DropDown not visible
> autocomplete.c:651: Test failed: AutoComplete DropDown not visible
> autocomplete.c:651: Test failed: Expected L"hfoo", got (null)
> autocomplete.c:651: Test failed: AutoComplete DropDown not visible
> autocomplete.c:651: Test failed: Expected L"https://hta", got (null)
> autocomplete.c:651: Test failed: AutoComplete DropDown not visible
> autocomplete.c:654: Test failed: Expected L"hta", got L"ht"
> autocomplete.c:655: Test failed: AutoComplete DropDown not visible
> autocomplete.c:655: Test failed: AutoComplete DropDown not visible
> autocomplete.c:655: Test failed: Expected L"https://hta", got (null)
> autocomplete.c:655: Test failed: AutoComplete DropDown not visible
> autocomplete.c:667: Test failed: Expected L"http://a0", got L"http://a"
> autocomplete.c:668: Test failed: AutoComplete DropDown not visible
> autocomplete.c:668: Test failed: AutoComplete DropDown not visible
> autocomplete.c:668: Test failed: Expected L"http://a0", got (null)
> autocomplete.c:668: Test failed: AutoComplete DropDown not visible
> autocomplete.c:668: Test failed: Expected L"http://abc.aa.com", got (null)
> autocomplete.c:668: Test failed: AutoComplete DropDown not visible
> autocomplete.c:675: Test failed: AutoComplete DropDown not visible
> autocomplete.c:675: Test failed: AutoComplete DropDown not visible
> autocomplete.c:675: Test failed: Expected L"http://a0", got (null)
> autocomplete.c:675: Test failed: AutoComplete DropDown not visible
> autocomplete.c:675: Test failed: Expected L"http://abc.aa.com", got (null)
> autocomplete.c:675: Test failed: AutoComplete DropDown not visible
> autocomplete.c:681: Test failed: AutoComplete DropDown not visible
> autocomplete.c:681: Test failed: AutoComplete DropDown not visible
> autocomplete.c:681: Test failed: Expected L"file://aa", got (null)
> autocomplete.c:681: Test failed: AutoComplete DropDown not visible
> autocomplete.c:681: Test failed: Expected L"ftp://abc", got (null)
> autocomplete.c:681: Test failed: AutoComplete DropDown not visible
> autocomplete.c:681: Test failed: Expected L"ftp://www.aa", got (null)
> autocomplete.c:681: Test failed: AutoComplete DropDown not visible
> autocomplete.c:685: Test failed: AutoComplete DropDown not visible
> autocomplete.c:685: Test failed: AutoComplete DropDown not visible
> autocomplete.c:685: Test failed: Expected L"file://aa", got (null)
> autocomplete.c:685: Test failed: AutoComplete DropDown not visible

Of course, there are still rare failures. These failures don't seem
specifically triggered by these changes, since they just make it more
robust (setting cursor twice / avoiding 0,0 and increasing sleep time if
necessary).

It's a step forward at least; the failures with multiple displays and
the ones where it didn't autocomplete (bug 53202) seem gone.