7 Feb
2023
7 Feb
'23
12:26 p.m.
On Tue Feb 7 12:26:41 2023 +0000, Zebediah Figura wrote:
Since we have names for `D3DSPDM_NONE` and `D3DSPSM_NONE`, it would
probably be a good idea to use them instead of zeroes? Otherwise, that seems fine. It seems unnecessary (perhaps even counterproductive) when dealing with flags arguments, but I don't feel strongly about it.
Ah, wait, but `D3DSHADER_PARAM_SRCMOD_TYPE` and `D3DSHADER_PARAM_DSTMOD_TYPE` behave differently. The former doesn't seem to behave like a bitmask, the latter does. So my personal suggestion is that we should use `D3DSPSM_NONE` rather than `0`, and `0` rather than `D3DSPDM_NONE`.
But I'm not going to die on that hill.