Re: [PATCH v8 0/6] MR459: vkd3d-shader/dxil: Implement the DXIL VSELECT instruction.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about tests/shader_runner.c:
> +static void read_uint64(const char **line, uint64_t *u)
> +{
> - char *rest;
> - uint64_t val;
> -
> - errno = 0;
> - val = strtoull(*line, &rest, 0);
> -
> - if (errno != 0 || (*rest != '\0' && !isspace((unsigned char)*rest)))
> -
>    fatal_error("Malformed uint64 constant '%s'.\n", *line);
> -
> - *u = val;
> - *line = rest;
>
> +}
> -
>
> +static void read_int64_t4(const char **line, struct i64vec2 *v)

Shouldn't this be `read_int64_t2`?

Also, nitpick time: I don't know if the name `int64_t2` is already established somewhere, I had never heard of it, but if it's not I'd drop the `t`. I suppose it's there by analogy with `int64_t` from `stdint.h`, but we're not really tracking C types here anyway, so I don't think it is particularly useful.