Re: [PATCH 0/6] MR717: vkd3d-shader/fx: Add initial support for writing fx_2_0 parameters.

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about libs/vkd3d-shader/fx.c:
> - {
> -
>    elements_count = hlsl_get_multiarray_size(type);
> -
>    type = hlsl_get_multiarray_element_type(type);
> - }
> - else
> - {
> -
>    elements_count = 1;
> - }
> -
> - size = get_fx_2_type_size(type) * elements_count;
> -
> - /* FIXME: write actual initial value */
> - offset = put_u32(buffer, 0);
> -
> - for (i = 1; i < size / sizeof(uint32_t); ++i)
> -
>    put_u32(buffer, 0);

This kind of thing bothers me. I know we can't reach here without already hitting an earlier hlsl_fixme(), but it seems too easy to fix that case and forget about this one. Yeah, I know d3dbc does the same thing.

I suppose I may just have to live with it.