8 Dec
2022
8 Dec
'22
11:16 a.m.
- The async test is broken on Windows 10 1507. This appears to be a trend among WinRT dlls. I'm thinking that we can add macro definitions for each testbot VM to avoid having to skip tests that would otherwise be working fine, and just greater control over tests in general.
I think it's alright as long as the test is run at least on some VMs. Having finer version detection and version checks may make things a bit less clear and not necessarily help telling genuine broken results from outdated one: how would we detect that a version is not run anymore?
- The provider file that contains `interface IWineAsyncInfoImpl` is likely going to be reused again in the future. Perhaps a new file can be added in the include/wine folder to prevent duplicate code? I can do this in a separate merge request and cleanup the existing provider files.
Yes, though we need to figure how best we can share code between all the WinRT libraries. I'm thinking maybe a static `win(e)rtbase` could be appropriate, but having global headers also isn't very well appreciated in general, so it needs some thinking. Especially if we want to use IDLs for private helper classes. In the meantime duplicating the code shouldn't be too bad.
Related to https://gitlab.winehq.org/wine/wine/-/merge_requests/1045.