Re: [PATCH v2 0/9] MR209: vkd3d-shader/hlsl: Broaden resources support v2, part 3.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/tpf.c:
> -
>    if (!(name = hlsl_strdup(ctx, var->name)))
> -
>    {
> -
>        sm4_free_extern_resources(extern_resources, *count);
> -
>        *count = 0;
> -
>        return NULL;
> -
>    }
> -
> -
>    extern_resources[*count].var = var;
> -
>    extern_resources[*count].name = name;
> -
>    extern_resources[*count].data_type = var->data_type;
> -
> -
>    extern_resources[*count].regset = regset;
> -
>    extern_resources[*count].id = var->regs[regset].id;
> -
>    extern_resources[*count].bind_count = var->regs[regset].bind_count;
> -
> -
>    extern_resources[*count].user_packed = var->reg_reservation.reg_type;

That's probably not required by the language, but maybe adding a `!!` here can make the conversion more explicit and the programmer's intention easier to understand.