Re: [PATCH v2 0/2] MR497: vkd3d-shader/dxil: Implement DX intrinsic Unary.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/dxil.c:
> -
>        WARN("Ignoring function attachment.\n");
> -
>        vkd3d_shader_parser_warning(&sm6->p, VKD3D_SHADER_WARNING_DXIL_IGNORING_ATTACHMENT,
> -
>                "Ignoring a metadata function attachment.");
> -
>        continue;
> -
>    }
> -
> -
>    index = record->operands[0];
> -
>    if (!target_block->record_count || index >= target_block->record_count - 1)
> -
>    {
> -
>        WARN("Invalid record index %"PRIu64".\n", index);
> -
>        vkd3d_shader_parser_error(&sm6->p, VKD3D_SHADER_ERROR_DXIL_INVALID_OPERAND,
> -
>                "Invalid record index %"PRIu64" for a metadata attachment.", index);
> -
>        continue;
> -
>    }
> -
>    /* 'index' is an instruction index, but records[0] is DECLAREBLOCKS, not an instruction. */
> -
>    target_block->records[index + 1]->attachment = record;

Maybe we could warn if that record already has an attachment.