Re: [PATCH v2 0/1] MR7769: ntdll: correctly detect the NUL device under macOS

[John Szakmeister (＠jszakmeister)]

On Thu Apr 10 20:45:53 2025 +0000, Brendan Shanks wrote:
> This seems reasonable to me, but I think it would be cleaner to put it
> after the `switch` block, like:
> switch (d_type)
> {
> ...
> }
> /* no special d_type for parallel ports */
> #if defined(__APPLE__)
> /* /dev/null on has been 3, 2 since the start of OSX */
> if (d_type == D_DISK && major(st.st_rdev) == 3 && minor(st.st_rdev) == 2)
>     info->DeviceType = FILE_DEVICE_NULL;
> #endif

I'll give it a go tomorrow and see what it looks like.  I had it where it was to avoid the unnecessary call to ioctl() as we can fully make the decision about the type right then and there.  But you have much more experience with Wine and what's more in line with what's preferred by the project, so I'm happy to defer to that experience. :-)