On Wed Jul 27 18:12:52 2022 +0000, Derek Lesho wrote:
In my opinion having the ifdef inside the function improves readability and is a bit more idiomatic, because you don't have to consider whether the function signature is different based on preprocessor conditions, and you know it's only the implementation that differs. Whether it warrants a patch though, ����
resolving with "undecided whether improvement"