On Wed Dec 18 16:31:16 2024 +0000, Zhiyi Zhang wrote:
It would be nice to have an ASan stage in Gitlab CI to catch these issues. I tried ASan a few years ago and I was unable to get it working. Maybe it's much easier now. Did you do anything special or following https://gitlab.winehq.org/wine/wine/-/wikis/Building-Wine#memory--address-ch... is enough?
Having PE-ASan in CI at the end would be great, but unfortunately my attempt involved building llvm-mingw/llvm-project with a few patches, which I attempted upstreaming for quite some time. Then building wine with it needs also a few patches, and running it involves currently an ugly mix of a non-ASan and an ASan build. Some more old/outdated details are [here](https://gitlab.winehq.org/wine/wine/-/merge_requests/6791#note_86908), for running just the executables below wine/programs.
But running the tests locally produced quite a few unfinished [patches](https://gitlab.winehq.org/bernhardu/wine/-/commits/asan-pe_2024-12-18) where I try to get the more obvious and hopefully freeze-compatible ones in, while waiting on progress with llvm-project.