Re: [PATCH v4 0/2] MR979: d3d9: Implement d3dx_effect_SetRawValue

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/effect.c:
> static HRESULT WINAPI d3dx_effect_SetRawValue(ID3DXEffect *iface, D3DXHANDLE parameter, const void *data,
>          UINT byte_offset, UINT bytes)
>  {
> - FIXME("iface %p, parameter %p, data %p, byte_offset %u, bytes %u stub!\n",
> - struct d3dx_effect *src = impl_from_ID3DXEffect( iface );

I guess you took inspiration from the previous function, but I think here it would be better to call the effect variable "effect" instead.