Re: [PATCH 0/6] MR536: xactengine3_7: Add helper function to add entries

[Zebediah Figura]

On 7/27/22 08:28, Giovanni Mascellani (@giomasce) wrote:
> Giovanni Mascellani (@giomasce) commented about dlls/xactengine3_7/xact_dll.c:
> >   XACT_GETOVERLAPPEDRESULT_CALLBACK pGetOverlappedResult;
> >   XACT_NOTIFICATION_CALLBACK notification_callback;
> >
> > - void *wb_prepared_context;
> > - void *wb_destroyed_context;
> > - void *contexts[17];
>
> Is this magic constant a good idea? Unfortunately we don't have a maximum constant for the notification types, but I'd rather go with `XACTNOTIFICATIONTYPE_MAX` and tolerate the wasted memory than leave a magic constant.

Or we could just define our own constant.