Re: [PATCH v9 0/10] MR4982: Load and play MIDI

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/dmime/midi.c:
> - case MIDI_META_SEQUENCE_NUMBER:
> - case MIDI_META_CHANNEL_PREFIX_ASSIGNMENT:
> - case MIDI_META_END_OF_TRACK:
> - case MIDI_META_SET_TEMPO:
> - case MIDI_META_SMPTE_OFFSET:
> - case MIDI_META_TIME_SIGNATURE:
> - case MIDI_META_KEY_SIGNATURE: return TRUE;
> -
> - case MIDI_META_TEXT_EVENT:
> - case MIDI_META_COPYRIGHT_NOTICE:
> - case MIDI_META_TRACK_NAME:
> - case MIDI_META_INSTRUMENT_NAME:
> - case MIDI_META_LYRIC:
> - case MIDI_META_MARKER:
> - case MIDI_META_CUE_POINT:
> - case MIDI_META_SEQUENCER_SPECIFIC: return FALSE;

Are we actually going to use all these events? As far as I can see they are not, so I would suggest to simplify the code and event union, only supporting fixed length events, skipping over variable length ones (with a FIXME).