On Mon Jul 3 09:42:19 2023 +0000, Rémi Bernon wrote:
It is confusing that the third bool parameter here is not whether the interface is supported or not, but a "broken" flag. You should keep the same API as the usual check_interface calls elsewhere. For the broken case I'd suggest to either
- not check that interface, possibly keeping it as commented with an
explanation, or,
- add a fourth optional parameter (only the function, and the macro
would pass FALSE to it), and use the function call for that interface only.
Makes sense, will be fixed in the next version