On Sat Jan 11 12:19:31 2025 +0000, Jinoh Kang wrote:
You missed s/CloseHandle/FindClose/ at line 2889. Although, arguably, global fixes like thisshould be part of a separate patchset for easier review. (My previous review was about *new* usages of FindClose/CloseHandle, not existing onces. I don't think existing incorrect code should block this MR or any others)
Ah oops. Will fix. But I personally think it's too trivial to split in a separate MR, especially since it's for tests only.
BTW it's fine to take your time with your variant, we're in code freeze anyway.