On Wed Apr 24 22:21:11 2024 +0000, Ally Sommers wrote:
This patch still works on master with all tests passing and the software I use it for still works as expected. I think it would be great for this to be merged, but the deletion code not being up to scratch is an understandable barrier. The first version was even worse. However, at the time I did spend a while looking at ways to get deletion working, and this was the least problematic solution I could come up with. I unfortunately can't really do much more than that unless a more specific criticism than "it's ugly" (which, again, I agree with) is levied. A nominally cleaner solution would probably introduce a lot of extra code just for this one special case, which seems undesired based on feedback for a previous patch of mine, so I'm hesitant to even attempt that. If anyone has any ideas, though, I'm all ears.
@zfigura "be considered ready by the submitter" doesn't means a patch is ready.
I think a lot of good MRs are being submitted and left into dust, a system that allow MRs to be aproved by other developers would allow more MRs to be accepted, like for example, a lot of simple stubs are not being merged and someone passing though MRs found out that https://gitlab.winehq.org/wine/wine/-/merge_requests/5522 code was a containing a duplicate of https://gitlab.winehq.org/wine/wine/-/merge_requests/2374 cause the stub was required to run an installer.
My proposed solution is in no way perfect, but it's still far better than right now, where multiple peoples are developing the same code for wine.