On Fri Oct 27 22:14:46 2023 +0000, Yuxuan Shui wrote:
see https://gitlab.winehq.org/wine/wine/-/merge_requests/3067#note_49787
I think this deserves more consideration. First we don't currently shut down sinks the same way Windows does, that sort of prevents seeing what happens with this grabber. We should fix that first.
Second, for the grabber, locking does not match what we do. On Windows, blocking in OnProcessSample() does not prevent shut down sequence. So this needs some more manual testing of the sample grabber, to see what happens when OnProcessSample() is blocked, but clock state callbacks are called for example, do they produce events or not, that sort of thing.
After that we'll see if changing call order in the media engine is still useful.