On Tue Jun 20 00:50:00 2023 +0000, Francisco Casas wrote:
No, wait. That's not it. Ignore my previous comment. There is even a test that says:
% Register reservations force to reserve all the resource registers. Even if unused.I see now that what we ought to do is ignore overlaps when one of the objects with register reservations is not used. So this MR is correct regarding that. Ugh, I will answer again then:
Francisco, is there a reason we're doing that? Why does
get_allocated_object() check that flag? We have to make sure that those spaces are reserved, even if the object is not used, like in the test with the previous comment.
This is hopefully better now, 'allocated' is removed now at the end, but still set to mark reserved slots. There was another error handling difference that I found and fixed - it's not a problem for unused variables to have wrong regset in their reservations.