Re: [PATCH v3 0/5] MR1733: mshtml/jscript/vbscript: Implement SID_GetCaller and misc fixes.

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/jscript/tests/caller.c:
>      IDispatch_AddRef(stored_obj);
>      break;
>
> - case DISPID_TEST_TESTGETCALLER:
> -
>    ok(wFlags == DISPATCH_METHOD, "wFlags = %x\n", wFlags);
> -
>    ok(pdp != NULL, "pdp == NULL\n");
> -
>    ok(!pdp->rgdispidNamedArgs, "rgdispidNamedArgs != NULL\n");
> -
>    ok(!pvarRes, "pvarRes != NULL\n");
> -
>    ok(pei != NULL, "pei == NULL\n");
> -
> -
>    if(pdp->cArgs == 0) {

Please use separated functions instead of tricks like that. test_get_caller_func global variable could also probably be avoided if you structure the test a bit better.