Re: [PATCH v11 0/4] MR6423: Implement NtQuerySystemEnvironmentValueEx, NtQuerySystemInformation SystemBootEnvironmentInformation, GetFirmwareType, GetFirmwareEnvironmentVariable*

[Grigory Vasilyev (＠h0tc0d3)]

On Thu Sep  5 18:52:07 2024 +0000, Alfred Agrell wrote:
> This throws a warning on 32bit builds.
> ../dlls/ntdll/unix/system.c:3698:47: error: format '%X' expects argument
> of type 'unsigned int', but argument 5 has type 'long unsigned int' [-Werror=format=]
>  3698 |
>
>
>
>
>
>
>
>
>
>
>
>
>
> "/sys/firmware/efi/efivars/%s-%08X-%04X-%04X-%02X%02X-%02X%02X%02X%02X%02X%02X",
> cname,
>       |                                            ~~~^
>       |                                               |
>       |                                               unsigned int
>       |                                            %08lX
>  3699 |              vendor->Data1, vendor->Data2, vendor->Data3,
> vendor->Data4[0], vendor->Data4[1],
>       |              ~~~~~~~~~~~~~                     
>       |                    |
>       |                    long unsigned int
>
> They're both uint32, so I'd prefer if compiler could just shut up.
> But we can't really affect that on our end. Let's just explicitly cast
> to (unsigned).

Done.