On Tue Nov 7 12:57:56 2023 +0000, Giovanni Mascellani wrote:
It seems that here you're keeping the minimum and maximum shader model just to account for the fact that the DXC compiler might or might not exist. Can't you just test that in `d3d12_runner_check_requirements()`?
Currently the only way we are identifying the runner in the test files are trace messages like the following: ``` trace("Compiling shaders with vkd3d-shader and executing with vkd3d\n"); trace("Compiling shaders with dxcompiler and executing with vkd3d\n"); ``` To be consistent with these, the tests that use vkd3d-shader as a compiler must be separated from the tests that use dxcompiler.
I would like more the `d3d12_runner_check_requirements()` alternative, but we would have to add the compiler and the runner using vkd3d_test_push_context(), instead of using these separator trace messages, which is something that I also like but may bring even more discussion.