Re: [PATCH v7 0/2] MR6904: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour

[eric pouech (＠epo)]

eric pouech (@epo) commented about dlls/ntdll/tests/directory.c:
> - sprintf(buf, "%s\%s", testdir, "a-file.h");
> - ret = DeleteFileA(buf);
> - ok( ret || (GetLastError() == ERROR_FILE_NOT_FOUND) || (GetLastError() == ERROR_PATH_NOT_FOUND),
> -
>   "Failed to rm %s, error %ld\n", buf, GetLastError() );
> -
> - sprintf(buf, "%s\%s", testdir, "another-file.h");
> - ret = DeleteFileA(buf);
> - ok( ret || (GetLastError() == ERROR_FILE_NOT_FOUND) || (GetLastError() == ERROR_PATH_NOT_FOUND),
> -
>   "Failed to rm %s, error %ld\n", buf, GetLastError() );
> -
> - RemoveDirectoryA(testdir);
>
> +}
> -
> -
>
> +/* Performs a query with NtQueryDirectoryFile() */
> +static BOOL test_NtQueryDirectoryFile_mask(HANDLE handle, BOOL restart_scan, UNICODE_STRING *mask,

it looks to me that the test would be more complete if instead of check_name_and_length argument you'd pass a unicode string (assuming all STATUS_SUCCESS should have a matching UNICODE_STRING), while the status returning an error should have a NULL unicode string. and the test below for the returned string should be tested agains that string and not the input mask